Files
group_fqcd_jr/tests/unit/service/test_customer_benefit_service.py
T
wangjianlong_0626 4766e3bd98 feat(benefit): 客户权益功能(T010)+ 修投顾迁移契约里写死 head 的脆弱断言
## 1. 新增客户权益(用户端)

`GET /api/v1/users/me/entitlements`(T010,权限 `benefit:read:self`):

- **层级**由 `fin_customer_profile.total_asset` **实时判定**
  (门槛来自 `knowledge/product/高净值客户服务规范.md`:
  金卡 50 万 / 白金 200 万 / 钻石 600 万 / 私行 1000 万;低于 50 万为普通客户);
- **权益按层级累积展开**(文档原文"含全部下级权益,新增以下"):
  金卡 9 条 / 白金 20 / 钻石 33 / 私行 54,各档已逐档实测;
- 返回**升级提示**(`next_tier`:下一层级与门槛),前端可直接渲染"再投 X 元升级"。

### 新增表 `fin_customer_benefit`(1 张)

层级 → 权益目录,54 条种子数据(`tools/seed_customer_benefits.py`,按 `benefit_code` 幂等)。

**基线合规证明**(规则 1/3/4):只新增这一张表;**未**重命名/删除任何已有表;
**未**重命名/删除/复用任何已有字段,**未**改任何已有字段的类型、可空性或业务含义;
未改 `docs/00`。
复核:`tools/audit_schema.py` → `90 business tables, no missing or unexpected tables`。

### 两条设计取舍

1. **不落"某客户享有哪些权益"**:层级可算,权益由层级推出,两者都不落库。
   与 `docs/00` L159(不保留 `net_worth_flag`,因为可算)同一取向。
2. **权益只存各层新增条目**,累积由服务层 `tier_chain()` 展开 ——
   否则改一条权益要改四处,漏一处就出现"白金没有金卡权益"。

### 数据来源与一处刻意省略

逐条照抄知识文档,不新增文档里没有的权益。**私行那条
「7×24小时私人银行专线:400-XXX-XXXX 转 8」不写号码** ——
文档里是占位符,而对客号码的唯一来源是 `customer_service_rules.CONTACT_PHONE`
(本线此前修过"同一客服给客户两个不同号码"的缺陷)。把占位符抄进库等于再造一份假号码。

## 2. 修投顾迁移契约里写死的断言

`tests/unit/test_advisor_migration_contract.py` 原先断言

```python
assert script.get_heads()[0] == "20260911_merge_adv_risk_heads"
```

那是"投顾迁移刚加完那一刻"的快照 —— 本 PR 一新增迁移(`20260912_customer_benefit`)
它就变红,**而红的原因与投顾链的对错无关**:断言测到的是时间,不是契约。

原意是"投顾链接在这条主链上、没另起分支"。改为断言**投顾链尾是当前 head 的祖先**
(链尾从 `ADVISOR_FILES[-1]` 派生,不写死),既保住原意又不受后续迁移影响。
`len(script.get_heads()) == 1`(链不分叉)与"投顾文件首尾相接"两条原样保留。

## 3. 顺带发现的既有缺口(**不在本次改动范围**)

`app/api/controllers/trading.py` 的 **T001–T009 未调用 `AuthorizationService.require`**:
`docs/05` §19 为它们登记了权限码(`account:read:self` / `trade:order:*` / `holding:read:self`),
但代码只做认证 + 开户测评门槛,**没有执行 RBAC 权限检查**。
对照:仓库里 **26 个 service** 都调了 `require`,`trade_service` 不在其中。

本线的 T010 **按正确做法实现**:`CustomerBenefitService.entitlements_for` 先鉴权再读数据,
且**鉴权在读取客户资产之前**(有测试断言"拒绝时未查库")。
T001–T009 如何补,需架构师定口径后另行处理。

## 4. 文档

- 新增 `docs/41-客户权益功能说明.md`:表登记 + 基线合规证明 + 分层口径 + 累积规则 +
  数据来源 + 权限 + 与仪表盘的关系 + 上述缺口
- `docs/05` §19 登记 T010,并**单独注明它引入了新表**(避免被误读为
  "T 段数据库零变更"的一部分)
- `AGENTS.md` 表数 89 → **90** 张业务表

## 验证

- `pytest tests/unit/service/test_customer_benefit_service.py` → **20 passed**
  (含边界:499999.99 不是金卡、500000 整是金卡、1000 万整是私行;累积条数;升级提示;
  鉴权先于读数据)
- 全量 `pytest tests` → `2 failed, 1469 passed, 1 skipped`
  (2 个失败为既有环境项:httpx 把中文序列化成 `\uXXXX`,非本次引入)
- `ruff check app tests tools alembic` → `All checks passed`
- `mypy app` → **0 错 / 252 文件**
- 真机:`GET /users/me/entitlements` → `200`;各档分层与累积条数逐档实测通过
- `audit_schema.py` → 90 张业务表无缺失/意外;文档守卫 55 份无编号冲突;
  端点编号无重复;RBAC 种子一致性通过
2026-09-12 17:24:37 +08:00

183 lines
6.6 KiB
Python

"""客户权益服务的定向测试:分层判定、累积展开、升级提示、鉴权。
权益条目由 `tools/seed_customer_benefits.py` 灌入(54 条)。本测试**不查库**,
用替身 session 直接给条目,保证分层与展开逻辑可独立验证。
"""
from decimal import Decimal
from typing import Any
import pytest
from app.core.contracts import RequestContext
from app.core.errors import ForbiddenAgentError
from app.model.benefit import CustomerBenefit
from app.service.customer_benefit_service import (
TIERS,
CustomerBenefitService,
resolve_tier,
tier_chain,
)
def benefit(code: str, tier: str, order: int) -> CustomerBenefit:
return CustomerBenefit(
id=order, benefit_code=code, customer_tier=tier, category="financial",
name=f"{tier}-{order}", description="d", display_order=order,
status="active", created_at=None, updated_at=None, # type: ignore[arg-type]
)
#: 与种子同一形状:每层条数不同,便于断言累积后的总数。
ALL: list[CustomerBenefit] = [
*[benefit(f"g{i}", "gold", i) for i in range(1, 10)], # 9
*[benefit(f"p{i}", "platinum", 100 + i) for i in range(1, 12)], # 11
*[benefit(f"d{i}", "diamond", 200 + i) for i in range(1, 14)], # 13
*[benefit(f"v{i}", "private", 300 + i) for i in range(1, 22)], # 21
]
class FakeSession:
"""只实现 `scalars`:把 `in_(codes)` 近似成"返回全部",由服务侧过滤数量断言。"""
def __init__(self, rows: list[CustomerBenefit]) -> None:
self.rows = rows
self.last_codes: tuple[str, ...] = ()
async def scalars(self, statement: Any) -> list[CustomerBenefit]:
# 从编译后的 SQL 参数里取层级码,保证"只取该层级及以下"确实生效。
params = statement.compile().params
codes = tuple(v for k, v in params.items() if "customer_tier" in str(k))
flat: list[str] = []
for c in codes:
if isinstance(c, str):
flat.append(c)
else:
flat.extend(str(x) for x in c)
self.last_codes = tuple(flat)
return [r for r in self.rows if r.customer_tier in self.last_codes]
# --- 分层判定 ---------------------------------------------------------------
@pytest.mark.parametrize(
("amount", "expected"),
[
(None, None),
("0", None),
("499999.99", None), # 差 1 分不到金卡
("500000", "gold"), # 门槛含等号
("1999999.99", "gold"),
("2000000", "platinum"),
("5999999", "platinum"),
("6000000", "diamond"),
("9999999", "diamond"),
("10000000", "private"), # 1000 万整
("99999999", "private"),
],
)
def test_resolve_tier_boundaries(amount: str | None, expected: str | None) -> None:
"""门槛含等号、边界不外溢 —— 这类 off-by-one 在金额分层里最容易错。"""
spec = resolve_tier(Decimal(amount) if amount is not None else None)
assert (spec.code if spec else None) == expected
def test_tiers_are_ordered_high_to_low() -> None:
"""`TIERS` 必须从高到低:`resolve_tier` 取第一个命中,`tier_chain` 依赖该顺序。"""
thresholds = [t.min_total_asset for t in TIERS]
assert thresholds == sorted(thresholds, reverse=True)
def test_tier_chain_is_accumulating_and_ordered_low_to_high() -> None:
assert tier_chain(next(t for t in TIERS if t.code == "gold")) == ("gold",)
assert tier_chain(next(t for t in TIERS if t.code == "platinum")) == ("gold", "platinum")
assert tier_chain(next(t for t in TIERS if t.code == "private")) == (
"gold", "platinum", "diamond", "private",
)
# --- 累积展开 ---------------------------------------------------------------
@pytest.mark.asyncio
@pytest.mark.parametrize(
("amount", "tier", "count"),
[
("500000", "gold", 9),
("2000000", "platinum", 20), # 9 + 11
("6000000", "diamond", 33), # 9 + 11 + 13
("10000000", "private", 54), # 9 + 11 + 13 + 21
],
)
async def test_benefits_accumulate_with_tier(amount: str, tier: str, count: int) -> None:
"""文档写明"含全部下级权益,新增以下" ⇒ 高等级必须拿到低等级的全部条目。"""
session = FakeSession(ALL)
data = await CustomerBenefitService(session).entitlements( # type: ignore[arg-type]
total_asset=Decimal(amount)
)
assert data["tier"] == tier
assert len(data["benefits"]) == count
# 低等级条目必须在场(累积的直接证据)
assert any(b["tier"] == "gold" for b in data["benefits"])
@pytest.mark.asyncio
async def test_below_lowest_threshold_gets_no_benefits_but_keeps_upgrade_hint() -> None:
"""低于 50 万是"普通客户",不是错误:权益空,但仍告诉他要多少才升级。"""
session = FakeSession(ALL)
data = await CustomerBenefitService(session).entitlements( # type: ignore[arg-type]
total_asset=Decimal("100")
)
assert data["tier"] is None
assert data["tier_label"] == "普通客户"
assert data["benefits"] == []
assert data["next_tier"] == {
"tier": "gold", "tier_label": "金卡", "min_total_asset": "500000.00",
}
# 未达门槛时不应去查权益表
assert session.last_codes == ()
@pytest.mark.asyncio
async def test_top_tier_has_no_next_tier() -> None:
data = await CustomerBenefitService(FakeSession(ALL)).entitlements( # type: ignore[arg-type]
total_asset=Decimal("50000000")
)
assert data["tier"] == "private"
assert data["next_tier"] is None
# --- 鉴权 -------------------------------------------------------------------
class FakeCtx:
def __init__(self, permissions: set[str]) -> None:
self.user_id = "9102"
self.permissions = permissions
self.roles: set[str] = set()
self.portal = "api"
@pytest.mark.asyncio
async def test_missing_permission_is_denied_before_touching_data(
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""权限检查必须在读取任何客户数据**之前**(避免"拒绝请求却已经查了库")。"""
service = CustomerBenefitService(FakeSession(ALL)) # type: ignore[arg-type]
called = {"n": 0}
async def spy(customer_id: int) -> Decimal | None:
called["n"] += 1
return Decimal("10000000")
monkeypatch.setattr(service, "_total_asset", spy)
ctx = RequestContext.model_construct(
user_id=9102, permissions=frozenset(), roles=frozenset(),
portal="api", trace_id="t", request_id="r",
)
with pytest.raises(ForbiddenAgentError):
await service.entitlements_for(ctx)
assert called["n"] == 0